Repository navigation
fix: resolve ShellCheck findings in the check and its tests - #1
Merged
Merged
Conversation
The case-clash check in hook mode now walks the folder with a glob instead of parsing ls output, so unusual file names cannot confuse it. The other findings were intentional single quotes and a false positive, now annotated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The first CI run failed in ShellCheck before the tests ran. One finding was real: the hook-mode case-clash check parsed
lsoutput, which unusual file names can break; it now uses a glob. The rest were intentional single quotes (a literal$) and a false positive, now annotated. Twocdcalls in the tests gained an|| exit 1.How it was tested
bash tests/check-standard.test.sh: 59 passed, 0 failed (macOS bash 3.2). CI runs ShellCheck and the tests on Linux.Checklist
🤖 Generated with Claude Code