Repository navigation
Collection Settings: Help button for the page showing (BL-17032) - #8489
Conversation
|
[Claude Opus 5.5 from Andrew Polk's machine during preflight] Consulted Devin on 2026-10-20 up to commit 244df74. One finding, the unpublished Config-R version, is open on its thread until 1.0.0-alpha.30 is in. |
|
[Claude Opus 5.5 from Andrew Polk's machine during preflight] Consulted Devin on 2026-10-23 up to commit af22717. It repeated only the pinned-Config-R finding, which that commit already fixes (alpha.30); its thread is resolved. |
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 9 files and all commit messages, and resolved 1 discussion.
Reviewable status: 0 of 9 files reviewed, all discussions resolved.
The dialog's bottom bar gets a Help button that opens the help topic for the page showing. Config-R 1.0.0-alpha.30 reports that page (onTopLevelPageChange). Languages, Front & Back Matter and Subscription keep the old dialog's topics; the other pages use the general Settings topic. Adds unit tests for the topic choice, an e2e test that intercepts the help request, and notes in the plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
af22717 to
aa605ef
Compare
|
[Low impact] The PR appears safe to merge; no actionable new issue was established.
|
StephenMcConnel
left a comment
There was a problem hiding this comment.
@StephenMcConnel reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on andrew-polk).
Problem
The new (React) Collection Settings dialog has no Help button. The old WinForms dialog opened a help topic for the tab showing. Config-R, which draws the dialog's pages, could not tell the dialog which page was showing, and could not switch pages while the dialog stayed open.
Fix
ConfigrPanegainsonTopLevelPageChange, which reports the showing page's key, andselectedTopLevelPageKey, which switches to a page while the pane stays mounted, keeping the user's edits.initiallySelectedTopLevelPageKeyworks as before. BL-16734 will use the switch to replace itspaneRemountworkaround.Screenshots
The dialog's bottom bar, with Help at the left:
After a change that needs a restart, the restart message sits after Help, and OK reads Restart:
Risk Evaluation
Low. The change only reaches the new Collection Settings dialog, which is still being built alongside Old Settings. The bottom-left group now always has Help in it, and the restart message moved into the same group after it.
Not caused here, but now easy to reach: Bloom's existing
helprequest never replies. After about six Help presses in one session, help stops changing topic and other requests stall too (for example OK no longer relabels to Restart). Every React Help button has this; it is tracked as BL-17033.Ecosystem Impact
@sillsdev/config-r1.0.0-alpha.30 (from alpha.29). That release only adds to Config-R's API, so nothing else that uses it changes.Common.Help.E2E Coverage
collection-settings-help.spec.ts: opens the dialog, shows each of the seven pages, clicks Help, and checks which topic Bloom was asked for. The test answers the help request itself, so no help window opens.Notion Test Suite
Preflight report: https://bloombooks.github.io/dev-process-artifacts/deciders/bloomdesktop-bl-17032-settings-help-2.html
Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-17032
🤖 Generated with Claude Code
Devin review
This change is