Repository navigation
feat(skills): add skill info view, mention insertion, and path-free catalog - #68
Conversation
…atalog - Skills dialog gains an info view (ctrl+i) with source open in the configured editor - Enter on a skill inserts `@name` at the cursor - Skill mentions get the same color as agent mentions; agent names win on collision - Skill catalog in the system prompt drops `<location>` paths; the skill tool loads bodies by name - Add `estimate_skill_catalog_tokens` for catalog token counts - Extract file actions (copy, reveal, open) into `App::perform_file_action` - Add `title_note` to `Dialog` for muted secondary header text
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying crabcode with
|
| Latest commit: |
f997178
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b3b4df5.crabcode.pages.dev |
| Branch Preview URL: | https://skills-dialog-mentions.crabcode.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 325ca38486
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for skill in &autocomplete.skills { | ||
| if names | ||
| .iter() | ||
| .any(|name| name.eq_ignore_ascii_case(&skill.name)) | ||
| { | ||
| continue; | ||
| } | ||
| names.push(skill.name.clone()); |
There was a problem hiding this comment.
This adds skill names only to the composer’s mention list. After an enabled skill is inserted or autocompleted and the message is submitted, rendering switches to Chat, but App::new_chat, chat_with_messages, and startup still give Chat only visible_agent_names_for_mentions(). Consequently @codebase-design is colored while drafting but loses its mention color in the rendered message and after session restoration; pass the eligible skill names into the chat mention list as well.
Useful? React with 👍 / 👎.
- Assert skill file paths and file:// URLs stay out of subagent and prompt skill guidance - Add test that paste while skill info is open does not change the search query - Verify long skill paths wrap after "/" and filenames stay on one line - Drop assertions on title note, token estimate, and color inequality
1 participant
@nameat the cursor<location>paths; the skill tool loads bodies by nameestimate_skill_catalog_tokensfor catalog token countsApp::perform_file_actiontitle_notetoDialogfor muted secondary header text