Repository navigation
test: cover Base deposits and strengthen Zcash rejection checks - #126
Draft
BitHighlander wants to merge 1 commit into
Draft
BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
Replay two observed Base THORChain deposits with signer recovery and refusal controls. Make Zcash fingerprint and account-path tests require the intended refusal, with valid signing and path-only controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOP correction: this fork draft is supplemental test preparation. Firmware staging retains the canonical upstream keepkey/python-keepkey #197 head
c1cb6afab2a60f6d20f196940c933bfcfabee106. These changes must be reconciled into that canonical PR branch before release adoption. Human upstream review and upstream dependency master merges precede firmware develop merges; firmware upstreaming comes last.Two Zcash rejection tests could pass on unrelated failures. Use a complete PCZT spend with a matching-fingerprint signing control, require the exact fingerprint refusal without action streaming or signature release, and check a valid path-only address request before the exact bad-path refusal.
Add the two observed Base THORChain deposit vectors, sign them with AdvancedMode disabled, recover the expected wallet signer, and reject unrelated router addresses and chains. The four-file change affects tests and fixtures; API and runtime behavior are unchanged.
Validation:
4e9ba27fda482060b7bf7776006276e5d89bc99f) with the pinned PYK source.478ec1c32b3925729e16b4899345a1246589d626.849a75bc6bc62fda701c18fb91a30588fa8055b5has byte-identical PCZT and Zcash source files to the integrated firmware used for the focused Zcash proof.Base:
c1cb6afab2a60f6d20f196940c933bfcfabee106(reconcile/upstream-sync). Keep this PR in draft during preparation so the automatic review workflow stays gated.CI run 38484575571, attempt 2 and CircleCI canonical-smoke passed at
8f73901d0a2262d8df16c28aaf13ee875ab80d6f. Full 7.15: 968 methods passed, 113 skipped and 342 passing subtests; full 7.14.3: 605 passed, 476 skipped and 211 passing subtests. Both BTC boundary rows passed 11/11 with no skips. The three focused Zcash methods and Base replay passed on 7.15, including all eight Base module methods. Successful replay transaction IDs are not individually logged; their coverage follows from the exact two-record fixture and passing loop. The unchanged workflow emits JUnit summary logs but uploads no raw XML; saved job logs retain the counts and case outcomes. Attempt 1 was interrupted by a runner shutdown after the new cases passed; only its failed job was rerun, without changing this head.The superseded historical firmware candidate for BitHighlander/keepkey-firmware#982 passed with this fork-only Python pin at firmware
3a78bd69e77861ab3d1d95bab5bf267243a4c3a6: full main raw wire XML is 1,000 passed/92 skipped, with all four new/corrected methods passing. Keep the different firmware pins and collection scopes separate.Firmware #982 now restores canonical upstream pins and the upstream keepkey#197 report URL at
d7bc25bf35c0e9110407c0dd17d49290066f7251. This fork commit is no longer adopted by that candidate.