Repository navigation
Document firmware limits and align protocol lockfile identity - #56
Draft
BitHighlander wants to merge 1 commit into
Draft
BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EIP-712 comments promise universal document support and a single request per member path, while firmware 7.15 enforces bounded shapes and repeats paths for chunks and verified review passes. Document those limits, correct the Hive role typo, and align the four lockfile root identity fields with
package.json(@keepkey/device-protocol7.14.1).Validation against
998c445f587da76fd70b552bc72bf6aa52a6a582:ae6a4570c434dc9a2103e5dab0d4b6c73ed0edc11b363a1b4655eebd8785b30c.This fork draft is supplemental patch preparation. Firmware staging must continue to pin the exact canonical upstream keepkey/device-protocol #112 head. Before release adoption, these changes must be reconciled into that canonical PR branch and validated there. Fetchability of a fork commit through an upstream GitHub origin is insufficient. Human upstream review and upstream dependency master merges precede firmware develop merges; firmware upstreaming comes last.
Local package checks also passed under Node20.19.5:
npm ci, package build/tests, generated JavaScript/TypeScript bindings, all18 protocol descriptors and the Zcash contract check. Full descriptor bytes remain identical (SHA25662ce620275782c3c4ae0c51e61a2dccaf571fa3f64ce59d1038c63d07e518149). This fork snapshot base is excluded by the existing Protocol CI target filters; local macOS validation is supplemental. The prior fork-pin aggregate run is superseded for release staging; corrected firmware #982 restores upstream keepkey#112’s exact head.