Skip to content

Upgrade Android Lint to 32.5.1 - #170

Draft
Bencodes wants to merge 1 commit into
mainfrom
bencodes/android-lint-32.5.1
Draft

Bencodes wants to merge 1 commit into
mainfrom
bencodes/android-lint-32.5.1

Conversation

@Bencodes

@Bencodes Bencodes commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Upgrade the bundled Lint CLI, API, checks, and model from 32.4.1 to 32.5.1 and regenerate the runtime Maven lock. The repo’s own lint results are unchanged on its fixtures, but the new engine is not binary-compatible with every precompiled custom check.

  • Custom checks: LintXmlConfiguration.IssueData gained a suppressNames parameter. A caller compiled against the old parameterized constructor or copy succeeds on 32.4.1 and throws NoSuchMethodError on 32.5.1. I reproduced both failures on the actual deploy jars and verified that a caller rebuilt with the new signature works. The README documents rebuilding or pinning the old engine. sdk-common also drops ddmlib; checks that used it cannot assume the host still bundles it. Neither dependency is used by the repo’s own code or its Compose check fixture.
  • Diagnostics: The registry adds three checks enabled by default (ThreadPriorityConfusion, SynchronizeOnValueBasedClass, MissingExplicitUriGrant) and two opt-in checks (GuardedBy, Immutable). Four Wear warnings are now off by default; SquareAndRoundTilePreviews is retained as an alias for TilePreviews. A Java source that synchronizes on an Integer produced a clean report on 32.4.1 and an error on 32.5.1 with warnings-as-errors.
  • Runner compatibility: Both releases use Java 17 bytecode and detector API level 16. The worker’s reflective entry points and CLI switches are present. The project-descriptor reader, XML reporter, baseline matcher and custom-jar registry sources are unchanged. No runner or baseline edits were needed.

Validation: All 29 root tests passed with real worker execution; all eight integration tests also passed with local execution. Compared eight fixture reports plus both standalone Android example reports before/after: identical apart from the engine stamp and temporary path. Covers clean/dirty findings, disabled checks, baseline filtering and custom checks loaded directly and from an AAR. One real persistent worker also switched 32.4.1 → 32.5.1 → 32.4.1 across three requests with dependency checking enabled; only the 32.5.1 request reported the new synchronization finding. On macOS the standalone example used prebuilt protoc on both versions to avoid an unrelated Xcode SDK include-path failure.

Android 9.5 release notes · 32.4.1 Lint API sources · 32.5.1 Lint API sources · Changed upstream type · 32.5.1 detector sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant