Skip to content

Expand network-aware General Settings - #25

Merged
BenCodez merged 3 commits into
mainfrom
codex/general-settings-network-20260929
Sep 30, 2026
Merged

BenCodez merged 3 commits into
mainfrom
codex/general-settings-network-20260929

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • expand the curated General Settings editor with source-verified backend and proxy settings
  • add network-aware Online Mode and Bedrock prefix synchronization with per-node state and fail-closed topology checks
  • make proxy AllowUnJoined authoritative while preserving the required backend AllowUnjoined: true prerequisite
  • surface AutoCreateVoteSites recommendations, configuration mismatches, and restart-required outcomes
  • preserve comments, ordering, unknown YAML, redactions, revisions, and the existing preview/approval/apply workflow

Compatibility

  • keeps the existing config.files.v1 and config.proxy-files.v1 capability contracts
  • older, offline, unsupported, and partial nodes remain visible and are excluded explicitly
  • no configuration is written while reading the page
  • proxy configuration writes are reported as requiring a full proxy restart

Validation

  • node --check for app.js, general-settings.js, and configuration-state.js
  • node --test src/test/web/*.test.cjs (124 passed)
  • mvn -B clean verify (275 passed)
  • git diff --check
  • fresh independent read-only Codex review: No findings

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 808cc2eb-7bcb-4792-9da0-23e188d9c2e2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T04:31:20.601817Z 2eaf4e1 PR opened
🔒 Security Review ✅ Completed 2026-09-29T04:32:48.079145Z 2eaf4e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2eaf4e10d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/app.js Outdated
@BenCodez
BenCodez merged commit 19cf4e2 into main Sep 30, 2026
2 checks passed
@BenCodez
BenCodez deleted the codex/general-settings-network-20260929 branch September 30, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant