[victor-tucci]

The PUBLIC tag was dropped in 7ab6f70, so daemons running with --restricted-rpc refused this call. Wallets depend on it in is_transfer_unlocked(); when it fails they assume nothing is blacklisted and also skip the staked-contribution check, which inflates unlocked balance and can pick unspendable outputs.

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• New Features
  • The master-node blacklisted key images query is now available through the public RPC interface. Its request format remains unchanged, so existing integrations can continue using the same request structure.

The GET_MASTER_NODE_BLACKLISTED_KEY_IMAGES declaration now includes PUBLIC alongside NO_ARGS. Its name and request shape remain unchanged.

Changes: RPC command declaration

Layer / File(s)	Summary
Add PUBLIC marker src/rpc/core_rpc_server_commands_defs.h	GET_MASTER_NODE_BLACKLISTED_KEY_IMAGES now inherits PUBLIC and NO_ARGS. Its name and request shape are unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: deen-kakarot

Merge Risk: Minimal · up to e99e3

This change restores the blacklisted key images call for daemons running with restricted RPC, so wallets can again check staked contributions when computing unlocked balances. No concrete merge risk was found.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the change: restoring the PUBLIC tag on the get_master_node_blacklisted_key_images RPC. The raw summary confirms that the struct declaration in core_rpc_server_commands_defs.h now carr…
Description check		The description explains why the change is needed. It states that the PUBLIC tag was dropped in an earlier commit, so daemons running with --restricted-rpc refuse the call. It also describes the walle…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the change: restoring the PUBLIC tag on the get_master_node_blacklisted_key_images RPC. The raw summary confirms that the struct declaration in core_rpc_server_commands_defs.h now carries PUBLIC, NO_ARGS. The title is specific and matches the single-line change.

Full details: Description check

Explanation

The description explains why the change is needed. It states that the PUBLIC tag was dropped in an earlier commit, so daemons running with --restricted-rpc refuse the call. It also describes the wallet impact in is_transfer_unlocked(). This relates directly to the changeset.

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the RPC line,
“PUBLIC” joins the quiet sign.
“NO_ARGS” stays just as before,
The command keeps its name in store.
I nibble clover, hop away,
One small change to mark today.}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 18abe274-1c8e-433e-9a35-38170181fa09

Commits

Reviewing files that changed from the base of the PR and between 4cd63fd and e99e3a7.

Files selected for processing: 1

• src/rpc/core_rpc_server_commands_defs.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.