Repository navigation
build: support Ubuntu 26.04 LTS - #241
Merged
victor-tucci merged 7 commits intoNov 14, 2026
Merged
victor-tucci merged 7 commits into
victor-tucci merged 7 commits into
Conversation
fix(rpc): prevent daemon crash on non-object JSON-RPC requests
Ubuntu 26.04 ships GCC 15.2, CMake 4.2 and Boost 1.90, which broke the build at configure and compile time. Fix each breakage while keeping the existing build path unchanged on older toolchains. Build system: - Boost 1.89+ removed the boost_system stub library, so stop requesting the "system" component. FindBoost still pulls it in as a dependency of thread on old Boost versions that need it, and an INTERFACE Boost::system target is defined when none exists so existing references keep working. - CMake 4 rejects cmake_minimum_required(VERSION < 3.5). Set CMAKE_POLICY_VERSION_MINIMUM=3.5 around the vendored googletest (ignored by older CMake), and on CMake >= 4.0 provide the bundled libzmq 4.3.4 build ourselves with the policy floor passed through (loki-mq uses a pre-existing libzmq target as-is). Older CMake keeps using loki-mq's own libzmq build. - GCC 15 no longer includes <cstdint> transitively; force-include it for the vendored cpr and its consumers (cpr/callback.h uses intptr_t). - GCC 14+ reports false-positive -Wdangling-reference inside vendored fmt 8; keep it as a warning but not an error (GCC >= 14 only). Code: - oaes_lib.c: swap transposed calloc() arguments (-Wcalloc-transposed-args); allocation size is unchanged. - quorumnet_conn_matrix.h: replace static_assert(N != N) with a dependent-false helper (-Wtautological-compare). - net_node.inl: std::remove_if() on a std::list without erase() never removed anything, so used-stripe peers were never removed and duplicates accumulated. Use std::list::remove_if(), matching the upstream Monero fix. This is a behaviour fix on all versions. Tests: - Replace removed Boost.Asio APIs (io_service.hpp -> io_context.hpp, io_context::reset() -> restart()) in levin, net and net_load_tests. Verified full build (all + unit_tests) on Ubuntu 20.04, 22.04, 24.04 and 26.04, and the Dockerfile static build on 18.04 (gcc-9, Boost 1.83). token_security passes on 20.04-26.04; the unit test results are identical across all versions (the same 47 pre-existing failures).
The JSON variant of get_output_distribution only emitted a single distribution, so a caller selecting decoys for a privacy-token input had no way to get the token bucket or the output_indices mapping a bucket rank back to a real global index. Call m_core.get_output_distribution directly for both the native and token buckets, mirroring what the .bin variant already returns, and add filter_type (1 = native, 2 = token) plus output_indices to the JSON response. m_core is used instead of detail::get_output_distribution because that helper's cache does not key on bucket type: a native hit would return an empty output_indices for the token bucket and spin the caller forever.
fix: return per-bucket distributions in JSON get_output_distribution
daemon: make print_pool tolerant of missing/non-integer tx fields
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
victor-tucci
merged commit Nov 14, 2026
4d89104
into
Beldex-Coin:feature-privacy-token
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.