Repository navigation
perf(preload): stop preloading icon collection endpoints - #54
Merged
Merged
Conversation
Preloading every collection REST endpoint inflated page generation time and HTML payload weight.
petitphp
force-pushed
the
fix/disable-icon-routes-preload
branch
from
October 15, 2026 06:52
b813f06 to
00ec2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preloading every collection REST endpoint inflated page generation time and HTML payload weight.
Note
Low Risk
Editor bootstrap behavior changes (fewer inlined REST responses) but the collections index remains preloaded; main risk is a slightly slower first open of a collection picker if the client relied on preloaded per-collection payloads.
Overview
Stops preloading per-icon-collection REST routes in the block editor.
preload_rest_endpointsnow only adds/icons/v1/collections?context=editand no longer registers acontext=editpath for every registered collection.This cuts block-editor HTML/bootstrap work when many collections exist; individual collection icon data is expected to load on demand instead of being inlined up front.
Tests drop the assertion that each collection name appears in the preload list; coverage for the collections endpoint and preserving existing preload entries is unchanged.
Reviewed by Cursor Bugbot for commit 00ec2cc. Bugbot is set up for automated code reviews on this repo. Configure here.