Repository navigation
fix: link VoIP server sources into the x64 Windows dedicated server - #64
Open
AndreasLauvhjell wants to merge 1 commit into
Open
AndreasLauvhjell wants to merge 1 commit into
AndreasLauvhjell wants to merge 1 commit into
Conversation
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build fix: fixes the red ci-x64 job on main. The native x64 Windows dedicated server
(bf2_w64ded.exe) fails to link with LNK1120, 6 unresolved externals in BF2VoipServer::CBF2VoipServer
(ctor, dtor, Initialize, CreateInstance, Update, Shutdown) referenced from VoipServerInternal.cpp,
because the voice-server sources were only built into the x86 side DLL (BF2VoipServer_w32ded.dll).
The x64 Windows target now links bf2_voipserver_only_sources statically, the same way the Linux
image already does. Marked [CHOSEN, not recovered] in CMakeLists.txt since the native x64 port has
no retail image to follow. x86 and Linux are unchanged.
Files: CMakeLists.txt (7 lines).
Tested: msvc-x64 dedicated server <links / starts on port <not 16567>>. x86 build unchanged.
Local CI check
Local mirror of the Windows jobs in .github/workflows/build.yml, run on main (ccf3099)
plus #64, #65 and #66 together (not one by one), from empty build dirs:
Toolchain: VS 2026 (MSVC 19.51); CI uses VS 2022. Linux job not run locally.