Repository navigation
fix: accept newline-separated manifest path lists - #795
Merged
Suneha Bose (bosesuneha) merged 3 commits intoOct 15, 2026
Merged
Conversation
MANIFESTPATH (Azure Pipelines) and DEPLOYMENTMANIFESTPATH (GitHub Actions) feed the manifests input of KubernetesManifest@1 and Azure/k8s-deploy, which take multiple paths separated by newlines. The dirPath kind rejects newlines, so callers can no longer generate pipelines that deploy more than one manifest path. Add a dirPathList kind that validates each newline-separated entry with dirPathValidator, and use it for both variables. Both templates already render these values with jsonString, so newlines stay inside a single YAML scalar. A template test asserts every dirPathList variable is rendered through jsonString.
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MANIFESTPATH(Azure Pipelines) andDEPLOYMENTMANIFESTPATH(GitHub Actions) are passed to themanifestsinput ofKubernetesManifest@1andAzure/k8s-deploy, which accept multiple paths separated by newlines. ThedirPathkind rejects newlines, so these templates can't be generated for more than one manifest path. This adds adirPathListkind that validates each line withdirPathValidatorand uses it for both variables. Both templates already render these values withjsonString, so the newlines stay inside a single YAML value.Type of change
How Has This Been Tested?
go test ./.... Adds validator cases, a render test for both templates with multiple paths, and a test that everydirPathListvariable is rendered withjsonString.Checklist: