Repository navigation
Correct MicLiveness logSummary timeout wording to fail-closed - #329
Open
toufiqfarhan0 wants to merge 1 commit into
Open
toufiqfarhan0 wants to merge 1 commit into
toufiqfarhan0 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328
Problem
In
Sources/BlurtEngine/Audio/MicLiveness.swift,MicLiveness.logSummaryreturns"input liveness unconfirmed after \(cap) ms — proceeding, \(route)"whengap == nil.However, as designed and documented in
AGENTS.md("failing closed on timeout: the recorder is torn down andstart()throws.audioCaptureFailed"),MicCapture.start()does not proceed: it logs the summary at.errorlevel and strictly fails closed (throw BlurtError.audioCaptureFailed(...)).Having the log string say
"— proceeding"whileMicCapture.start()throws and aborts dictation creates confusion when diagnosing mic bring-up timeouts in system logs (log show --predicate 'subsystem == "dev.alex.blurt"').Fix
MicLiveness.logSummarywhengap == nilto say"— failing closed,"instead of"— proceeding,".Tests/BlurtEngineTests/MicLivenessTests.swiftto assert the updated string.Verification
scripts/check-invariants.shpassed.scripts/check-portability.shpassed.