Repository navigation
Treat URLError.cancelled as cancellation in awaitUpload - #326
Open
toufiqfarhan0 wants to merge 1 commit into
Open
toufiqfarhan0 wants to merge 1 commit into
toufiqfarhan0 wants to merge 1 commit into
Conversation
When an in-flight upload task throws URLError(.cancelled), treat it as cancellation in awaitUpload() rather than repainting the cancelled dictation as a red failure. Resolves AssemblyAI#324.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #324
In
DictationSession+Pipeline.swift:awaitUpload, cancelled in-flight requests that throwURLError(.cancelled)were not recognized as cancellation because the catch statement only checkedTask.isCancelled || error is CancellationError. In Swift,URLErroris not an instance ofCancellationError.When
uploadis cancelled (viacancelUpload(),cancelRecording(), orURLSessionaborts),URLError(.cancelled)fell through tosetPhase(.failed(.sttFailed(underlying: error))), erroneously repainting the cancelled dictation as a red failure and logging an error.This PR adds
|| (error as? URLError)?.code == .cancelled, matching the comment on line 205 (// (URLError(.cancelled) / CancellationError)) and the pattern used inSelectionSpeechRouter+Command.swiftandAssemblyAISpeechSynthesizer.swift.How it was tested
Added unit test
transcriberThrowingURLErrorCancelledIsIgnoredinCancelRaceTests.swiftasserting that a transcriber throwingURLError(.cancelled)does not set.failed.Verified repository integrity checks:
scripts/check-invariants.shpassed ("14 settled decisions hold").scripts/check-portability.shpassed ("37 shell scripts carry no GNU-only idioms").scripts/check-release-notes.shpassed.evals/dictation-prompt/test_eval.py) passed (151 passed).scripts/check.shpasses (or CI will, if I'm not on a Mac)I read AGENTS.md and this doesn't reintroduce anything deliberately removed
Docs updated if behavior changed