Repository navigation
feat(types): add four documented transcript options the SDK could not send - #314
Open
mayankbohradev wants to merge 1 commit into
Open
mayankbohradev wants to merge 1 commit into
mayankbohradev wants to merge 1 commit into
Conversation
… send The option models ignore unknown fields, so these were dropped from the request with no error: - speaker_options.include_speaker_confidence, with speaker_confidence on words and utterances in the response - language_detection_options.on_no_speech_detected - redact_pii_audio_options.return_redacted_no_speech_audio - redact_static_entities Each new parameter is last in its signature.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds four options that the
/v2/transcriptAPI documents but this SDK could not send:speaker_options.include_speaker_confidence,language_detection_options.on_no_speech_detected,redact_pii_audio_options.return_redacted_no_speech_audioandredact_static_entities.Why
The option models ignore unknown fields, so each of these was dropped from the request with no error.
on_no_speech_detected="fallback"still got a failed transcript on silent audio.speaker_confidencein a response was discarded, and was missing fromjson_responsetoo.redact_static_entitiescould not be set at all.How
SpeakerOptions.include_speaker_confidence, andspeaker_confidenceonWord, so words and utterances carry it.LanguageDetectionOptions.on_no_speech_detected, also a keyword ofset_language_detection.RedactPiiAudioOptions.return_redacted_no_speech_audio.redact_static_entitiesonTranscriptionConfig: constructor, property, andset_redact_pii(static_entities=...). Disabling redaction clears it, like the other redaction options, because the API rejects it withoutredact_pii.Testing
master; the other one guards that the field stays absent by default. Eight assert the captured request body.test_a_forked_child_does_not_share_the_parents_tts_connectionsfails on macOS onmastertoo.Notes for reviewers
on_no_speech_detectedis astr, to matchon_low_language_confidencebeside it.json_responsenow hasspeaker_confidence: Noneon a word when the API did not send it, the same asspeakerandchanneltoday.raw_transcription_config=are still reset by the constructor, as every option is today. fix(types): keep raw_transcription_config values and rebuild transcript.config from them #288 covers that.