Repository navigation
fix(mobile): zoom previews and sync Codex compose - #608
shenlvkang-collab wants to merge 3 commits into
Conversation
|
Thanks for this, @shenlvkang-collab! It adds pinch, pan and wheel zoom to the path picker's image preview, and it makes the mobile Compose dialog take over whatever is already typed in a Codex composer. Today Send just appends to that text, so this fixes a real problem. The zoom code is clean (the teardown in I ran the handoff against a real codex-cli 0.162.0. Two composer states go wrong, and both need fixing before merge:
Two smaller ones that are worth taking in the same round:
If you prefer, I can apply these at merge time:
One process note for next time: zoom and the Codex handoff are unrelated, and two PRs would have been quicker to review. Once 1 and 2 are fixed (and ideally 3 and 4), I'll merge it. |
|
Thanks for the follow-up, @shenlvkang-collab. This PR adds pinch, pan and wheel zoom to the path picker's image preview, and makes the mobile Compose dialog take over (and now mirror) whatever is typed in a Codex composer. The zoom part is in good shape. On the Codex side, Must fix before merge
Should fix in the same round
On the overall shape, I'd drop the per-keystroke mirroring and keep the dialog as the only owner of the prompt while it is open, which is how the Claude path works and what the Mobile prompt composer section of Please also update The merge-time items from my last comment still stand, and I'll do them myself: Once 1 to 3 are fixed (and ideally 4 to 6), I'll merge. If you'd like the zoom to land sooner, split it into its own PR and I can merge that one right away. |
What changed
Verification
test/mobile-prompt-composer.test.ts: 20 passed, including Codex live-sync and Claude handoff regression coverage.test/path-picker-ui.test.tsandpackages/xterm-zerolag-input/test/predictive-echo-addon.test.tspassed before this follow-up change.e00314b(run38149143773). The current headcbb291cadds documentation only; its CI is running.