Repository navigation
Reject unequal-length iterables in is_close - #955
Open
remote-controlled-man wants to merge 1 commit into
Open
remote-controlled-man wants to merge 1 commit into
remote-controlled-man wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_close()compares iterable inputs withzip(), so it ignores extra elements. As a result,test_close([1], [1, 999]), comparisons against an empty sequence, and nested length mismatches all pass when they should fail.Use
zip_longest()with a unique missing-value sentinel to reject unmatched elements before the recursive comparison. The change is in the owning notebook and its generated Python module. Scalar, string and array comparisons retain their existing paths.Regression tests cover unequal lengths in both directions, empty and nested sequences,
Nonevalues and iterators, alongside valid tolerance comparisons. The initialtest_closeregression fails on unmodified main and passes with this fix.Validation on macOS / Python 3.12:
nbdev-test --n-workers 2suite: passed.nbdev-test nbs/00_test.ipynb --n-workers 1: passed.git diff --check: passed.Prepared with OpenAI Codex.