Repository navigation
Merge NoteKeeper into a deployable full-stack web app - #1
Merged
Merged
Conversation
add features
AmirTahan80
marked this pull request as ready for review
July 22, 2026 07:53
Owner
Author
|
All validation is green: Angular 22 build and tests, .NET 10 build, dependency audits, Docker image build, and the PostgreSQL end-to-end authorization flow passed. This is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request combines
NoteKeeperFrontandNoteKeeperBackinto one production-ready web application while retaining the commit ancestry of both repositories.What changed
/apirequests and a development proxyPasswordHasherWhy
The frontend and backend previously required separate startup/configuration, used fixed localhost addresses, depended on SQL Server and MinIO, and contained authentication/authorization gaps that made a public deployment unsafe. The new layout produces one deployable container and keeps all user data in PostgreSQL.
Validation
dotnet build NoteBookKeeper.sln -c Release— passed with 0 warningsdotnet format NoteBookKeeper.sln --verify-no-changes— passeddotnet list ... package --vulnerable --include-transitive— no vulnerable NuGet packagesnpm run build— passednpm audit --omit=dev— 0 vulnerabilitiesscripts/e2e.ps1— registration, login, migrations, Angular serving, note/attachment flow, unauthenticated file protection, and cross-user isolation passed against an isolated PostgreSQL clusterdocker build -t notekeeper:local .— passedDeployment notes
render.yamlcan create the web service and PostgreSQL database from the repository. Render's free PostgreSQL database is temporary, so a paid Render database or another persistent PostgreSQL provider should be used for a long-lived portfolio demo.Any credentials reused from the old repositories should still be rotated because removing them from this new repository cannot remove them from the already-published history of the original repositories.