Repository navigation
timeline: regenerate releases, now including aw-android - #83
Conversation
|
| for release in sorted(releases, key=lambda r: r["created_at"], reverse=True) | ||
| if not release["draft"] and not SKIP_TAG.search(release["tag_name"]) |
There was a problem hiding this comment.
format_releases adds draft, nightly, and Research Edition filtering, but no tests cover these new rules. Add small release fixtures that check excluded tags, retained stable and beta tags, and the fallback for an empty release name. This would catch changes that silently remove valid history or add unwanted builds.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Added in 14b72a4: scripts/test_get_releases.py (same pattern as test_update_downloads.py) covers kept stable/beta tags, skipped drafts/nightlies/-research, newest-first order and the empty-name fallback. get-releases.py now runs its fetch under main so it's importable.
|
@greptileai review |
get-releases.py also fetches aw-android releases (previously a hand-maintained file that stopped at v0.10.0), skips drafts, nightlies and Research Edition builds, pages 100 at a time and accepts GITHUB_TOKEN. Adds v0.13.2, the v0.14.0 betas and aw-android v0.12.x-v0.14.2 to /timeline/.
14b72a4 to
4deaf4c
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| } | ||
|
|
||
|
|
||
| class FormatReleasesTest(unittest.TestCase): |
There was a problem hiding this comment.
CI calls only scripts/test_update_downloads.py, and no test discovery step includes scripts/test_get_releases.py. These new tests cannot catch broken release filters before merging. Add this file to the workflow so future filter changes are checked automatically.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
The /timeline/ page stopped at desktop v0.13.1 and Android v0.10.0.
scripts/get-releases.pynow also generates_data/releases_android.ymlfrom aw-android's GitHub releases (it was hand-maintained), skips drafts, nightlies (dev2026…) and Research Edition builds (-research), usesper_page=100andGITHUB_TOKENif set, and fails loudly on API errors.Draft until v0.14.0 is published: re-run
GITHUB_TOKEN=$(gh auth token) python3 scripts/get-releases.pyso v0.14.0 is included, then merge.