Repository navigation
Fix release-wheels: macOS deployment target 10.12 for the Intel Mac wheels - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
The proving run of the release-wheels workflow (run 38460717489, 2026-10-13) passed 6 of 7 jobs. The only failure was the Intel Mac wheel build (macos-15-intel), at the wheel repair step for the Python 3.10 wheel:
The newer Apple Silicon Mac build was unaffected, because its wheels already aim at a higher minimum.
The fix
One line in the cibuildwheel step's environment in
.github/workflows/release-wheels.yml:This tells the macOS wheel builds to use 10.12 as the minimum macOS version, matching what the compiled extension actually requires — the remedy the error message itself names. A comment above the line records why it is there. Nothing else in the workflow changes.
CHANGELOG.mdgains one line under Unreleased → Fixed describing the fix in plain language.Scope
This PR is only the fix. It does not merge itself, dispatches no workflow run, creates or pushes no tag, and publishes nothing. A separate proving run after merge is the coordinator's call.