Conversation
Pulls in the 1.72.1-1.72.4 upstream fixes: - blockchain: bound the rollback floor by the archiver's frontier and refuse targets the node could not start from - address: walk the drivers in a fixed id order so CheckAddress reports a deterministic error, and key its cache by the enabled drivers - system/dapp: tolerate the legacy checksum error below the base58 fork, which the deterministic driver order now surfaces as ErrCheckChecksum - account: GenesisInit rejects a negative amount instead of persisting a negative balance - db: bump goleveldb past the MANIFEST rotation table-file leak and cap the leveldb write buffer - p2p: accept a higher minor version in verLimit No new forks are registered in this range, so the fork toml templates need no new entries. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
- Coverage 29.12% 29.12% -0.01%
==========================================
Files 382 382
Lines 73475 73477 +2
==========================================
- Hits 21400 21399 -1
Misses 50087 50087
- Partials 1988 1991 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Note on the red The job times out at So the step is currently broken on master independent of this PR. Everything else is green, including |
Bumps
github.com/33cn/chain33from v1.72.0 to v1.72.4, picking up the 1.72.1–1.72.4 upstream fixes.What comes in
CheckAddresswalks the drivers in a fixed id order, so the reported error no longer depends on Go's randomized map iteration; the address cache is keyed by the enabled drivers.CheckAddresstolerates the legacy checksum error belowForkBase58AddressCheck. The deterministic driver order makes a 25-byte address reportErrCheckChecksumwhere it could previously come back asErrCheckVersion, so without this gate such an address would flip from "sometimes accepted" to "always rejected" on already-executed blocks.GenesisInitrejects a negative amount rather than persisting a negative balance; the upper bound stays atMaxTokenBalanceso existing blocks remain replayable.github.com/syndtr/goleveldbpin) and caps the leveldb write buffer.verLimitno longer blacklists peers on a higher minor version.Scope
Dependency-only change plus the transitive goleveldb pin. No new forks are registered anywhere in this range, so the fork toml templates need no new entries (unlike the v1.72.0 bump, which added
ForkAccountBlacklistV2).Verification
go build ./...— clean apart fromplugin/dapp/cross2eth/contracts/gnosis/{bsctest,chain33test}, which fail identically on master (pre-existing generated packages with nomain).go test -parallel=8 $(go list ./... | grep -v pbft)— 124 packages ok, 0 failures.🤖 Generated with Claude Code