Repository navigation
[fix] verify non-root container delivery (STAR-57) - #35
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 23 23
Lines 1128 1128
=======================================
Hits 974 974
Misses 117 117
Partials 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented Docker invocation failed because the image used a shell CMD: passing
-creplaced the command and Docker tried to execute-citself. The image also ran as root on an obsolete distribution baseline.Use a direct StarCLI entrypoint on Debian bookworm-slim, run as UID 65532, retain system CA certificates, and rely on the existing embedded time-zone data. Limit the build context to the prebuilt Linux binary. The README documents script mounts, resource limits, and loopback host publishing.
Closes the runtime-image portion of STAR-57; final release adoption remains tracked by STAR-104. Behavior changes: arguments now reach StarCLI directly; the working directory is
/work, the image user is non-root, and the documented HTTP port is 8080. Shell use requires an explicit entrypoint override.Validation:
docker stopunder a read-only filesystem and resource limits. HTTPS tests use a local fixture, not a public network dependency.