Conversation
arunsathiya
self-requested a review
August 1, 2023 12:33
AndyTitu
approved these changes
Aug 30, 2023
AndyTitu
left a comment
Contributor
There was a problem hiding this comment.
code lgtm to me mostly. I've left a couple of small comments which should be addressed before merging.
Author
|
@AndyTitu I did the changes |
Remove the need for string manipulation and instead return the password field directly, to simplify the code for readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add the possibility to use a stored password with ansible-vault to encrypt/decrypt strings and files.
Type of change
Related Issue(s)
How To Test
The output file
test.ymlshould be something similar to:Then to confirm:
Changelog
Add the possibilty to use a stored password as password-file to use with
ansible-vault.