From 234d53993faf890c7e7d71413b2204a5408252c3 Mon Sep 17 00:00:00 2001 From: calvinleng-science Date: Mon, 26 Oct 2026 19:13:46 -0700 Subject: [PATCH 1/3] chore: pin synapse-api 2.6.1 (signed threshold_uV); release 2.8.5 --- setup.py | 2 +- synapse-api | 2 +- synapse/_api_version.py | 2 +- synapse/tests/client/test_spike_detector.py | 10 ++++++++++ 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index 83a6ae84..52106ef5 100644 --- a/setup.py +++ b/setup.py @@ -29,7 +29,7 @@ def stamp_api_version(): setup( name="science-synapse", - version="2.8.4", + version="2.8.5", description="Client library and CLI for the Synapse API", author="Science Team", author_email="team@science.xyz", diff --git a/synapse-api b/synapse-api index f9fc77f6..05f87266 160000 --- a/synapse-api +++ b/synapse-api @@ -1 +1 @@ -Subproject commit f9fc77f6c3a9b5ccfa6479b48f139e7d540e8843 +Subproject commit 05f8726641d810f0d35fa90d3c4a271fc5db1946 diff --git a/synapse/_api_version.py b/synapse/_api_version.py index 445971de..3e7e1a17 100644 --- a/synapse/_api_version.py +++ b/synapse/_api_version.py @@ -1,2 +1,2 @@ # Generated from synapse-api/VERSION by setup.py. Do not edit. -SYNAPSE_API_VERSION = "2.6.0" +SYNAPSE_API_VERSION = "2.6.1" diff --git a/synapse/tests/client/test_spike_detector.py b/synapse/tests/client/test_spike_detector.py index b64dcad3..e7cc5b5d 100644 --- a/synapse/tests/client/test_spike_detector.py +++ b/synapse/tests/client/test_spike_detector.py @@ -83,3 +83,13 @@ def test_to_proto_template_matcher(): test_to_proto_template_matcher() print("All tests passed!") + + +def test_negative_threshold_round_trips(): + # threshold_uV is int32 (synapse-api 2.6.1): the sign is the crossing direction. + detector = SpikeDetector(samples_per_spike=32, config=ThresholderConfig(threshold_uV=-400)) + proto = detector._to_proto().spike_detector + assert proto.thresholder.threshold_uV == -400 + + wire = SpikeDetectorConfig.FromString(proto.SerializeToString()) + assert SpikeDetector._from_proto(wire).threshold_uV == -400 From dd6d7a12e7a57ce0c79baead694314de0f7f1f71 Mon Sep 17 00:00:00 2001 From: calvinleng-science Date: Mon, 26 Oct 2026 19:19:39 -0700 Subject: [PATCH 2/3] chore: re-point synapse-api submodule after its branch history was rewritten --- synapse-api | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse-api b/synapse-api index 05f87266..0b686d6f 160000 --- a/synapse-api +++ b/synapse-api @@ -1 +1 @@ -Subproject commit 05f8726641d810f0d35fa90d3c4a271fc5db1946 +Subproject commit 0b686d6fd44592d6aa07c6dd3045ee969411113e From 0d14b229e12c017135199409d0e57056ad0a1e77 Mon Sep 17 00:00:00 2001 From: calvinleng-science Date: Tue, 27 Oct 2026 12:06:06 -0700 Subject: [PATCH 3/3] chore: pin synapse-api to main (2.6.1, #86 merged) --- synapse-api | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse-api b/synapse-api index 0b686d6f..551deca8 160000 --- a/synapse-api +++ b/synapse-api @@ -1 +1 @@ -Subproject commit 0b686d6fd44592d6aa07c6dd3045ee969411113e +Subproject commit 551deca8d4f2cfd83be3264c371beb0b6fb70619