From 0226dd5ef8050a61c69d6036d5571aea92c3a5c9 Mon Sep 17 00:00:00 2001 From: "jargons-ai[bot]" <308145374+jargons-ai[bot]@users.noreply.github.com> Date: Sun, 27 Sep 2026 11:47:53 +0000 Subject: [PATCH 1/2] fix: apply Jargons review suggestions to src/routes/pricing.tsx --- src/routes/pricing.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/routes/pricing.tsx b/src/routes/pricing.tsx index ccb9a7c..55988b1 100644 --- a/src/routes/pricing.tsx +++ b/src/routes/pricing.tsx @@ -29,6 +29,8 @@ export const Route = createFileRoute('/pricing')({ // Sign in, then come back here and go straight into `target`'s checkout. function signInThenCheckout(target: PaidPlan) { + // The `target` parameter is already validated by `isPaidPlan` in `validateSearch` + // and is one of the known `PaidPlan` IDs. This ensures it's a controlled value. const next = `/pricing?checkout=${target}` window.location.assign(`/auth/sign-in?next=${encodeURIComponent(next)}`) } From 0070dd2acd61ce2bd13d7d0c38552dce2ee0159f Mon Sep 17 00:00:00 2001 From: "jargons-ai[bot]" <308145374+jargons-ai[bot]@users.noreply.github.com> Date: Sun, 27 Sep 2026 11:47:54 +0000 Subject: [PATCH 2/2] fix: apply Jargons review suggestions to src/server/github-auth.ts --- src/server/github-auth.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/github-auth.ts b/src/server/github-auth.ts index 3e0fcee..05f6bca 100644 --- a/src/server/github-auth.ts +++ b/src/server/github-auth.ts @@ -286,7 +286,7 @@ export async function setSignInNext(next: unknown): Promise { } setCookie(signInNextCookieName, path, { - maxAge: 60 * 10, + maxAge: 60, httpOnly: true, path: '/', sameSite: 'lax',