From 6bae44a6c45165f116d234f4da9fbc30a46f099c Mon Sep 17 00:00:00 2001 From: Rachel Pizane Date: Thu, 7 May 2026 16:41:08 -0300 Subject: [PATCH] =?UTF-8?q?[PETCONTROL-005]=20feat:=20implementar=20exclus?= =?UTF-8?q?=C3=A3o=20do=20pet=20e=20seus=20testes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../petcontrol/controller/PetsController.java | 16 +++++++++ .../controller/impl/PetsControllerImpl.java | 6 ++++ .../db/petcontrol/service/PetsService.java | 2 ++ .../service/impl/PetsServiceImpl.java | 7 ++++ ...155129__add_on_delete_cascade_pet_tags.sql | 8 +++++ .../controller/PetsControllerTest.java | 33 +++++++++++++++++-- .../integration/PetsIntegrationTest.java | 15 +++++++++ .../service/PetsServiceImplTest.java | 27 +++++++++++++++ 8 files changed, 112 insertions(+), 2 deletions(-) create mode 100644 src/main/resources/db/migrations/V20260507155129__add_on_delete_cascade_pet_tags.sql diff --git a/src/main/java/br/com/db/petcontrol/controller/PetsController.java b/src/main/java/br/com/db/petcontrol/controller/PetsController.java index 62c017a..19634f0 100644 --- a/src/main/java/br/com/db/petcontrol/controller/PetsController.java +++ b/src/main/java/br/com/db/petcontrol/controller/PetsController.java @@ -15,6 +15,7 @@ import java.util.UUID; import org.springdoc.core.annotations.ParameterObject; import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.DeleteMapping; import org.springframework.web.bind.annotation.GetMapping; import org.springframework.web.bind.annotation.PathVariable; import org.springframework.web.bind.annotation.PostMapping; @@ -91,6 +92,21 @@ public interface PetsController { ResponseEntity update( @PathVariable UUID id, @Valid @RequestBody PetRequestDTO dto); + @Operation(summary = "Deletar pet", description = "Deletar um pet pelo seu id") + @ApiResponse(responseCode = "204", description = "Pet deletado com sucesso") + @ApiResponse( + responseCode = "404", + description = "Pet não encontrado", + content = + @Content( + schema = @Schema(implementation = ErrorResponseDTO.class), + examples = + @ExampleObject( + name = "Pet não encontrado", + value = "{\"messages\": [\"Pet not found\"]}"))) + @DeleteMapping("/{id}") + ResponseEntity delete(@PathVariable UUID id); + @Operation(summary = "Buscar pets", description = "Retorna uma lista paginada de pets") @ApiResponse( responseCode = "200", diff --git a/src/main/java/br/com/db/petcontrol/controller/impl/PetsControllerImpl.java b/src/main/java/br/com/db/petcontrol/controller/impl/PetsControllerImpl.java index 1a18576..e1b897f 100644 --- a/src/main/java/br/com/db/petcontrol/controller/impl/PetsControllerImpl.java +++ b/src/main/java/br/com/db/petcontrol/controller/impl/PetsControllerImpl.java @@ -30,6 +30,12 @@ public ResponseEntity update(UUID id, PetRequestDTO dto) { return ResponseEntity.status(HttpStatus.OK).body(response); } + @Override + public ResponseEntity delete(UUID id) { + petsService.delete(id); + return ResponseEntity.status(HttpStatus.NO_CONTENT).build(); + } + @Override public ResponseEntity> findAll(PageableRequestDTO pageable) { PageResponseDTO response = petsService.findAll(pageable); diff --git a/src/main/java/br/com/db/petcontrol/service/PetsService.java b/src/main/java/br/com/db/petcontrol/service/PetsService.java index a655779..54bf62d 100644 --- a/src/main/java/br/com/db/petcontrol/service/PetsService.java +++ b/src/main/java/br/com/db/petcontrol/service/PetsService.java @@ -11,6 +11,8 @@ public interface PetsService { PetResponseDTO update(UUID id, PetRequestDTO dto); + void delete(UUID id); + PageResponseDTO findAll(PageableRequestDTO pageable); PetResponseDTO find(UUID id); diff --git a/src/main/java/br/com/db/petcontrol/service/impl/PetsServiceImpl.java b/src/main/java/br/com/db/petcontrol/service/impl/PetsServiceImpl.java index 1b726b4..ac2aa77 100644 --- a/src/main/java/br/com/db/petcontrol/service/impl/PetsServiceImpl.java +++ b/src/main/java/br/com/db/petcontrol/service/impl/PetsServiceImpl.java @@ -65,6 +65,13 @@ public PetResponseDTO update(UUID id, PetRequestDTO dto) { return petsMapper.toResponse(updatedPet); } + @Override + @Transactional + public void delete(UUID id) { + Pets pet = findPet(id); + petRepository.delete(pet); + } + @Override public PageResponseDTO findAll(PageableRequestDTO pageable) { Page page = diff --git a/src/main/resources/db/migrations/V20260507155129__add_on_delete_cascade_pet_tags.sql b/src/main/resources/db/migrations/V20260507155129__add_on_delete_cascade_pet_tags.sql new file mode 100644 index 0000000..285bc24 --- /dev/null +++ b/src/main/resources/db/migrations/V20260507155129__add_on_delete_cascade_pet_tags.sql @@ -0,0 +1,8 @@ +ALTER TABLE tb_pet_tags + DROP CONSTRAINT IF EXISTS fk_pet_id; + +ALTER TABLE tb_pet_tags + ADD CONSTRAINT fk_pet_id + FOREIGN KEY (pet_id) + REFERENCES tb_pets(id) + ON DELETE CASCADE; diff --git a/src/test/java/br/com/db/petcontrol/controller/PetsControllerTest.java b/src/test/java/br/com/db/petcontrol/controller/PetsControllerTest.java index 2d7a20c..8530071 100644 --- a/src/test/java/br/com/db/petcontrol/controller/PetsControllerTest.java +++ b/src/test/java/br/com/db/petcontrol/controller/PetsControllerTest.java @@ -3,8 +3,11 @@ import static org.hamcrest.Matchers.greaterThan; import static org.hamcrest.Matchers.hasSize; import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.doNothing; +import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put; @@ -259,8 +262,6 @@ void shouldUpdatePetSuccessfully() throws Exception { .content(JsonUtils.convertToJson(request))) .andExpect(status().isOk()) .andExpect(content().json(JsonUtils.convertToJson(response))); - - verify(petsService).update(petId, request); } @Test @@ -304,4 +305,32 @@ static Stream invalidPetRequestsProvider() { PetsFixture.requestDtoBuilder().status(null).build()); } } + + @Nested + class DeletePetTests { + @Test + void shouldDeletePetSuccessfully() throws Exception { + UUID petId = UUID.randomUUID(); + + doNothing().when(petsService).delete(petId); + + mockMvc + .perform(delete(PET_ID_URL, petId).contentType(MediaType.APPLICATION_JSON)) + .andExpect(status().isNoContent()) + .andExpect(content().string("")); + } + + @Test + void shouldReturnNotFoundWhenDeletingNonexistentPet() throws Exception { + UUID invalidId = UUID.randomUUID(); + String errorMessage = "Pet not found"; + + doThrow(new NotFoundException(errorMessage)).when(petsService).delete(invalidId); + + mockMvc + .perform(delete(PET_ID_URL, invalidId).contentType(MediaType.APPLICATION_JSON)) + .andExpect(status().isNotFound()) + .andExpect(jsonPath("$.messages[0]").value(errorMessage)); + } + } } diff --git a/src/test/java/br/com/db/petcontrol/integration/PetsIntegrationTest.java b/src/test/java/br/com/db/petcontrol/integration/PetsIntegrationTest.java index 693d27e..d9da285 100644 --- a/src/test/java/br/com/db/petcontrol/integration/PetsIntegrationTest.java +++ b/src/test/java/br/com/db/petcontrol/integration/PetsIntegrationTest.java @@ -397,6 +397,21 @@ void shouldUpdatePetSuccessfully() { } } + @Nested + class DeletePetTests { + @Test + void shouldDeletePetSuccessfully() { + Pets pet = builderWithoutId().build(); + Pets savedPet = petsRepository.save(pet); + + ResponseEntity response = + restTemplate.exchange(PET_ID_URL, HttpMethod.DELETE, null, Void.class, savedPet.getId()); + + assertEquals(HttpStatus.NO_CONTENT, response.getStatusCode()); + assertThat(petsRepository.findById(savedPet.getId())).isEmpty(); + } + } + public Pets.PetsBuilder builderWithoutId() { return PetsFixture.builder().id(null).species(savedSpecies); } diff --git a/src/test/java/br/com/db/petcontrol/service/PetsServiceImplTest.java b/src/test/java/br/com/db/petcontrol/service/PetsServiceImplTest.java index dd596ff..2822c07 100644 --- a/src/test/java/br/com/db/petcontrol/service/PetsServiceImplTest.java +++ b/src/test/java/br/com/db/petcontrol/service/PetsServiceImplTest.java @@ -409,4 +409,31 @@ void shouldThrowNotFoundExceptionWhenTagDoesNotExist() { verify(petRepository, never()).saveAndFlush(any()); } } + + @Nested + class DeletePetTests { + @Test + void shouldDeletePetSuccessfully() { + Pets existingPet = PetsFixture.builder().build(); + + when(petRepository.findById(existingPet.getId())).thenReturn(Optional.of(existingPet)); + + service.delete(existingPet.getId()); + + verify(petRepository, times(1)).delete(existingPet); + } + + @Test + void shouldReturnNotFoundWhenDeletingNonexistentPet() { + UUID invalidId = UUID.randomUUID(); + + when(petRepository.findById(invalidId)).thenReturn(Optional.empty()); + + assertThatThrownBy(() -> service.delete(invalidId)) + .isInstanceOf(NotFoundException.class) + .hasMessageContaining("Pet not found"); + + verify(petRepository, never()).delete(any()); + } + } }