From baeb753a42ec39f6c54d263e21e0b8d434386382 Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Fri, 19 Jun 2026 14:37:42 +0100 Subject: [PATCH] uprobe_dejitter: Make sure cr_prog < last_prog doesn't overflow Shouldn't happen in SRT but happens during pathological SRT streams --- lib/upipe/uprobe_dejitter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/upipe/uprobe_dejitter.c b/lib/upipe/uprobe_dejitter.c index c8f9e46a3..ce7f948cf 100644 --- a/lib/upipe/uprobe_dejitter.c +++ b/lib/upipe/uprobe_dejitter.c @@ -130,10 +130,10 @@ static int uprobe_dejitter_clock_ref(struct uprobe *uprobe, struct upipe *upipe, } /* phase-locked loop */ + int64_t prog_delta = (int64_t)cr_prog - (int64_t)uprobe_dejitter->last_cr_prog; uint64_t real_cr_sys = uprobe_dejitter->last_cr_sys + - (cr_prog - uprobe_dejitter->last_cr_prog) * - uprobe_dejitter->drift_rate.num / - uprobe_dejitter->drift_rate.den; + (uint64_t)(prog_delta * (int64_t)uprobe_dejitter->drift_rate.num / + (int64_t)uprobe_dejitter->drift_rate.den); int64_t real_offset = (int64_t)real_cr_sys - (int64_t)cr_prog; int64_t error_offset = real_offset - wanted_offset;