From 9719e83c0378fcf9bca52ed228f2bbba0ac051af Mon Sep 17 00:00:00 2001 From: Florian Vogt Date: Wed, 18 Nov 2026 16:01:58 +0100 Subject: [PATCH] feat: Adapt to agent-plugin spec while keeping Claude Code support - Add agent-plugin spec files (plugin.json + mcp.json in plugin dir) for the new spec - Keep Claude Code specific files (.claude-plugin/plugin.json and .mcp.json) so the plugins still work in Claude Code - Add $schema fields to plugin.json and mcp.json for validation - Remove inline skills[] array from plugin.json (now resolved by convention) - Update CI and release config to reflect new structure JIRA: CPOUI5FOUNDATION-1407 --- .github/workflows/ci.yml | 29 +++++++++---------- .prettierrc | 2 +- docs/Development.md | 10 ++++--- package.json | 2 +- .../plugin => .claude-plugin}/plugin.json | 5 +--- plugins/ui5-modernization/.mcp.json | 5 +++- plugins/ui5-modernization/mcp.json | 13 +++++++++ plugins/ui5-modernization/plugin.json | 6 ++-- .../plugin => .claude-plugin}/plugin.json | 3 -- plugins/ui5-typescript-conversion/plugin.json | 4 +-- .../plugin => .claude-plugin}/plugin.json | 3 -- plugins/ui5/.mcp.json | 5 +++- plugins/ui5/mcp.json | 13 +++++++++ plugins/ui5/plugin.json | 4 +-- release-please-config.json | 6 ++-- renovate.json | 3 +- 16 files changed, 66 insertions(+), 47 deletions(-) rename plugins/ui5-modernization/{.github/plugin => .claude-plugin}/plugin.json (88%) create mode 100644 plugins/ui5-modernization/mcp.json rename plugins/ui5-typescript-conversion/{.github/plugin => .claude-plugin}/plugin.json (92%) rename plugins/ui5/{.github/plugin => .claude-plugin}/plugin.json (94%) create mode 100644 plugins/ui5/mcp.json diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8baa02c1..37724049 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -49,23 +49,22 @@ jobs: - name: Verify plugin.json copies are in sync run: | set -eu - COPIES=( - ".github/plugin/plugin.json" - ) failed=0 for root in plugins/*/plugin.json; do dir=$(dirname "$root") - for rel in "${COPIES[@]}"; do - copy="$dir/$rel" - if [ ! -f "$copy" ]; then - echo "::error file=$copy::missing copy of $root" - failed=1 - continue - fi - if ! diff -u "$root" "$copy"; then - echo "::error file=$copy::differs from $root" - failed=1 - fi - done + copy="$dir/.claude-plugin/plugin.json" + if [ ! -f "$copy" ]; then + echo "::error file=$copy::missing copy of $root" + failed=1 + continue + fi + # Strip $schema from root (not present in .claude-plugin/plugin.json) before comparing + root_stripped=$(jq 'del(.["$schema"])' "$root") + copy_content=$(jq '.' "$copy") + if [ "$root_stripped" != "$copy_content" ]; then + diff <(echo "$root_stripped") <(echo "$copy_content") || true + echo "::error file=$copy::differs from $root" + failed=1 + fi done exit $failed diff --git a/.prettierrc b/.prettierrc index e5f804d2..3d5388e5 100644 --- a/.prettierrc +++ b/.prettierrc @@ -5,7 +5,7 @@ "singleQuote": false, "overrides": [ { - "files": ["**/plugin.json"], + "files": ["**/plugin.json", "**/mcp.json", "**/.mcp.json"], "options": { "parser": "json-stringify" } diff --git a/docs/Development.md b/docs/Development.md index 71f8c30f..15177673 100644 --- a/docs/Development.md +++ b/docs/Development.md @@ -22,12 +22,14 @@ Here's how a release comes together: 2. On every push to `main`, release-please quietly keeps a release pull request up to date (you'll recognize it by its `release: vX.Y.Z` title). It collects the pending changes into [CHANGELOG.md](../CHANGELOG.md) and bumps the version in every `plugin.json`. 3. When you're ready to ship, **rebase and merge that pull request.** release-please takes it from there: it tags the commit `vX.Y.Z` and cuts the matching GitHub Release. -One thing worth knowing: thanks to the `extra-files` setting in [release-please-config.json](../release-please-config.json), the version gets bumped in *two* copies of each plugin's manifest: +Each plugin contains four files that the version bump must keep in sync. Thanks to the `extra-files` setting in [release-please-config.json](../release-please-config.json), release-please bumps the version in the two `plugin.json` copies automatically: -- `plugins//plugin.json` — the one Claude Code actually reads. -- `plugins//.github/plugin/plugin.json` — a duplicate that the GitHub Copilot `awesome-copilot` smoke test insists on. +- `plugins//plugin.json` — the agent-plugin spec manifest (used by both marketplaces); carries a `$schema` field. +- `plugins//mcp.json` — the agent-plugin spec MCP server config; carries a `$schema` field. +- `plugins//.claude-plugin/plugin.json` — the Claude Code-specific copy of the manifest (no `$schema`). +- `plugins//.mcp.json` — the Claude Code-specific MCP server config (no `$schema`). -To make sure those two never quietly drift apart, [CI](../.github/workflows/ci.yml) checks that the `.github/plugin/plugin.json` copy is identical to the root one down to the byte. +The root `plugin.json` and its `.claude-plugin/plugin.json` counterpart must stay identical except for the `$schema` field. [CI](../.github/workflows/ci.yml) enforces this by stripping `$schema` from both files before comparing them. Once the release is out, jot down the version it produced — specifically the Git tag `vX.Y.Z`. You'll need it for the GitHub Copilot marketplace below. diff --git a/package.json b/package.json index 8197a3ae..0f7ef77a 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "knip": "knip", "lint:commit": "commitlint", "prepare": "node ./.husky/skip.js || husky", - "prettier": "prettier **/.mcp.json **/plugin.json", + "prettier": "prettier **/.mcp.json **/mcp.json **/plugin.json", "prettier:write": "npm run prettier -- --write", "prettier:check": "npm run prettier -- --check", "test": "npm run prettier:check && npm run knip && npm run check-licenses && npm run vally", diff --git a/plugins/ui5-modernization/.github/plugin/plugin.json b/plugins/ui5-modernization/.claude-plugin/plugin.json similarity index 88% rename from plugins/ui5-modernization/.github/plugin/plugin.json rename to plugins/ui5-modernization/.claude-plugin/plugin.json index 81cbf234..6d240053 100644 --- a/plugins/ui5-modernization/.github/plugin/plugin.json +++ b/plugins/ui5-modernization/.claude-plugin/plugin.json @@ -15,8 +15,5 @@ "linter", "upgrade" ], - "license": "Apache-2.0", - "skills": [ - "./skills/" - ] + "license": "Apache-2.0" } diff --git a/plugins/ui5-modernization/.mcp.json b/plugins/ui5-modernization/.mcp.json index fe0a866e..12539a5c 100644 --- a/plugins/ui5-modernization/.mcp.json +++ b/plugins/ui5-modernization/.mcp.json @@ -2,7 +2,10 @@ "mcpServers": { "chrome-devtools": { "command": "npx", - "args": ["-y", "chrome-devtools-mcp@latest"] + "args": [ + "-y", + "chrome-devtools-mcp@latest" + ] } } } diff --git a/plugins/ui5-modernization/mcp.json b/plugins/ui5-modernization/mcp.json new file mode 100644 index 00000000..18a5db0d --- /dev/null +++ b/plugins/ui5-modernization/mcp.json @@ -0,0 +1,13 @@ +{ + "$schema": "https://agent-plugins.org/schemas/1.0.0/mcp.schema.json", + "mcpServers": { + "chrome-devtools": { + "type": "stdio", + "command": "npx", + "args": [ + "-y", + "chrome-devtools-mcp@latest" + ] + } + } +} diff --git a/plugins/ui5-modernization/plugin.json b/plugins/ui5-modernization/plugin.json index 81cbf234..c962b5c4 100644 --- a/plugins/ui5-modernization/plugin.json +++ b/plugins/ui5-modernization/plugin.json @@ -1,4 +1,5 @@ { + "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json", "name": "ui5-modernization", "version": "0.1.9", "description": "Complete UI5 modernization toolkit with workflow and specialized fix patterns for modernizing SAPUI5/OpenUI5 applications", @@ -15,8 +16,5 @@ "linter", "upgrade" ], - "license": "Apache-2.0", - "skills": [ - "./skills/" - ] + "license": "Apache-2.0" } diff --git a/plugins/ui5-typescript-conversion/.github/plugin/plugin.json b/plugins/ui5-typescript-conversion/.claude-plugin/plugin.json similarity index 92% rename from plugins/ui5-typescript-conversion/.github/plugin/plugin.json rename to plugins/ui5-typescript-conversion/.claude-plugin/plugin.json index 322a4972..c74e2392 100644 --- a/plugins/ui5-typescript-conversion/.github/plugin/plugin.json +++ b/plugins/ui5-typescript-conversion/.claude-plugin/plugin.json @@ -16,8 +16,5 @@ "plugin", "typescript", "conversion" - ], - "skills": [ - "./skills/" ] } diff --git a/plugins/ui5-typescript-conversion/plugin.json b/plugins/ui5-typescript-conversion/plugin.json index 322a4972..ed48af1e 100644 --- a/plugins/ui5-typescript-conversion/plugin.json +++ b/plugins/ui5-typescript-conversion/plugin.json @@ -1,4 +1,5 @@ { + "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json", "name": "ui5-typescript-conversion", "version": "0.1.9", "description": "SAPUI5 / OpenUI5 plugin for coding agents. Converts JavaScript-based UI5 projects to TypeScript.", @@ -16,8 +17,5 @@ "plugin", "typescript", "conversion" - ], - "skills": [ - "./skills/" ] } diff --git a/plugins/ui5/.github/plugin/plugin.json b/plugins/ui5/.claude-plugin/plugin.json similarity index 94% rename from plugins/ui5/.github/plugin/plugin.json rename to plugins/ui5/.claude-plugin/plugin.json index 4212b00c..f24b94a0 100644 --- a/plugins/ui5/.github/plugin/plugin.json +++ b/plugins/ui5/.claude-plugin/plugin.json @@ -20,8 +20,5 @@ "api-documentation", "development-guidelines", "best-practices" - ], - "skills": [ - "./skills/" ] } diff --git a/plugins/ui5/.mcp.json b/plugins/ui5/.mcp.json index 0c4a79d9..200d8dc1 100644 --- a/plugins/ui5/.mcp.json +++ b/plugins/ui5/.mcp.json @@ -2,7 +2,10 @@ "mcpServers": { "ui5-mcp-server": { "command": "npx", - "args": ["-y", "@ui5/mcp-server@0.3.3"] + "args": [ + "-y", + "@ui5/mcp-server@0.3.3" + ] } } } diff --git a/plugins/ui5/mcp.json b/plugins/ui5/mcp.json new file mode 100644 index 00000000..a046dfc7 --- /dev/null +++ b/plugins/ui5/mcp.json @@ -0,0 +1,13 @@ +{ + "$schema": "https://agent-plugins.org/schemas/1.0.0/mcp.schema.json", + "mcpServers": { + "ui5-mcp-server": { + "type": "stdio", + "command": "npx", + "args": [ + "-y", + "@ui5/mcp-server@0.3.3" + ] + } + } +} diff --git a/plugins/ui5/plugin.json b/plugins/ui5/plugin.json index 4212b00c..e4b1903a 100644 --- a/plugins/ui5/plugin.json +++ b/plugins/ui5/plugin.json @@ -1,4 +1,5 @@ { + "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json", "name": "ui5", "version": "0.1.9", "description": "SAPUI5 / OpenUI5 plugin for coding agents. Creates and validates UI5 projects, accesses API documentation, runs UI5 linter, retrieves development guidelines and best practices for UI5 development.", @@ -20,8 +21,5 @@ "api-documentation", "development-guidelines", "best-practices" - ], - "skills": [ - "./skills/" ] } diff --git a/release-please-config.json b/release-please-config.json index ec9c5b30..f62f3289 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -71,7 +71,7 @@ }, { "type": "json", - "path": "plugins/ui5/.github/plugin/plugin.json", + "path": "plugins/ui5/.claude-plugin/plugin.json", "jsonpath": "$..version" }, { @@ -81,7 +81,7 @@ }, { "type": "json", - "path": "plugins/ui5-typescript-conversion/.github/plugin/plugin.json", + "path": "plugins/ui5-typescript-conversion/.claude-plugin/plugin.json", "jsonpath": "$..version" }, { @@ -91,7 +91,7 @@ }, { "type": "json", - "path": "plugins/ui5-modernization/.github/plugin/plugin.json", + "path": "plugins/ui5-modernization/.claude-plugin/plugin.json", "jsonpath": "$..version" } ] diff --git a/renovate.json b/renovate.json index a0aebce0..9f1c8cab 100644 --- a/renovate.json +++ b/renovate.json @@ -63,7 +63,8 @@ { "customType": "regex", "managerFilePatterns": [ - "/plugins/ui5/\\.mcp\\.json/" + "/plugins/ui5/\\.mcp\\.json/", + "/plugins/ui5/mcp\\.json/" ], "matchStrings": [ "@ui5/mcp-server@(?[^\"]+)"