From 3745d89acbd6f2a003ebb8bab40397e591c7239a Mon Sep 17 00:00:00 2001 From: S2D2 Date: Mon, 26 Oct 2026 17:42:46 +0000 Subject: [PATCH 1/3] ci(SEC-104): pin Node exactly in workflows Refs SEC-104. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/release.yaml | 2 +- .nvmrc | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9499d96..ba6383c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -59,7 +59,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version: 22 + node-version-file: .nvmrc cache: pnpm - name: Install Python dependencies @@ -165,11 +165,11 @@ jobs: version: 10.26.0 package_json_file: sdk-conformance/package.json - # 24, not 22: the Node SDK's devEngines pins Node ^24.11.0, and the suite runs on it too. + # The Node SDK's devEngines pins the exact Node version, and the suite runs on it too. - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version: 24 + node-version-file: stackone-ai-node/package.json - name: Install Node SDK dependencies working-directory: stackone-ai-node @@ -231,7 +231,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version: 22 + node-version-file: .nvmrc cache: pnpm - name: Install Python dependencies diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 1395437..2eb4090 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -92,7 +92,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version: 22 + node-version-file: .nvmrc - name: Install dependencies run: | diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 0000000..b8b23ca --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +22.23.4 From b97a183c95f0b5d2d813a204664ef94560e6d381 Mon Sep 17 00:00:00 2001 From: S2D2 Date: Mon, 26 Oct 2026 23:40:41 +0000 Subject: [PATCH 2/3] ci(SEC-104): pin Node in package.json devEngines instead of .nvmrc One source per repo: devEngines.runtime 22.23.4 (onFail: download) is read by setup-node (node-version-file: package.json) in CI and by pnpm locally, which downloads that exact runtime and records it in pnpm-lock.yaml. The lockfile integrity values match the official v22.23.4 SHASUMS256.txt (20/20 variants). Refs SEC-104. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yaml | 4 +- .github/workflows/release.yaml | 2 +- .nvmrc | 1 - package.json | 9 ++- pnpm-lock.yaml | 123 +++++++++++++++++++++++++++++++++ 5 files changed, 134 insertions(+), 5 deletions(-) delete mode 100644 .nvmrc diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ba6383c..515ee3b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -59,7 +59,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version-file: .nvmrc + node-version-file: package.json cache: pnpm - name: Install Python dependencies @@ -231,7 +231,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version-file: .nvmrc + node-version-file: package.json cache: pnpm - name: Install Python dependencies diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 2eb4090..3e65db8 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -92,7 +92,7 @@ jobs: - name: Setup Node uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 with: - node-version-file: .nvmrc + node-version-file: package.json - name: Install dependencies run: | diff --git a/.nvmrc b/.nvmrc deleted file mode 100644 index b8b23ca..0000000 --- a/.nvmrc +++ /dev/null @@ -1 +0,0 @@ -22.23.4 diff --git a/package.json b/package.json index b547f69..b790a66 100644 --- a/package.json +++ b/package.json @@ -14,5 +14,12 @@ "tsx": "^4.19.2", "zod": "4.1.13" }, - "packageManager": "pnpm@10.26.0" + "packageManager": "pnpm@10.26.0", + "devEngines": { + "runtime": { + "name": "node", + "version": "22.23.4", + "onFail": "download" + } + } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c1f3f5a..9cd9162 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -20,6 +20,9 @@ importers: hono: specifier: 4.13.13 version: 4.13.13 + node: + specifier: runtime:22.23.4 + version: runtime:22.23.4 tsx: specifier: ^4.19.2 version: 4.23.13 @@ -436,6 +439,124 @@ packages: resolution: {integrity: sha512-NMPBRMJgiQHjbd8phG3Vebdx4kZ1H121rbl5IkMqeOsahptB9BKo/d7oJ3zTXqTgagn2bWlNSXkh0QUGM31RYg==} engines: {node: '>=18'} + node@runtime:22.23.4: + resolution: + type: variations + variants: + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-whlBC+oK7Qjs+lhHo9ispORd1JSglPhsDYchE4Ngqck= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-aix-ppc64.tar.gz + targets: + - cpu: ppc64 + os: aix + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-yeHbx0izPtLRT0JEUZHsrxTFYlnHqaJtAELEnsK2ZCg= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-darwin-arm64.tar.gz + targets: + - cpu: arm64 + os: darwin + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-78wrDbb5S/U+3bA4/is3AnegQr0p5PGbj44jWYeVuBk= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-darwin-x64.tar.gz + targets: + - cpu: x64 + os: darwin + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-96HkhtvIsoaEeBW0d9T7Xp+5Y+1EicPhWIhT1oX1ifk= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-arm64.tar.gz + targets: + - cpu: arm64 + os: linux + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-Qxjgxo9i4YWD2uhetkX1XH8rii6NH//pGi6KvQRogKs= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-armv7l.tar.gz + targets: + - cpu: armv7l + os: linux + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-ZoSQPuJ5Wq/mOdwHID6KUe0grhYc8http8ITyKv+1EI= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-ppc64le.tar.gz + targets: + - cpu: ppc64le + os: linux + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-C9yA+iczHn9BbR2FU7mqu8PBWHCdwyhZ5OhXJKwawwI= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-s390x.tar.gz + targets: + - cpu: s390x + os: linux + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-YxiUAuqiIqq/UbSYPlElkhMc0tSp78Otm/KR/nTj5N4= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-x64-musl.tar.gz + targets: + - cpu: x64-musl + os: linux + - resolution: + archive: tarball + bin: bin/node + integrity: sha256-uEkihMdqVLr1jWFmjdDkHuD8mK2r+VA9MPBdCPVbRAY= + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-linux-x64.tar.gz + targets: + - cpu: x64 + os: linux + - resolution: + archive: zip + bin: node.exe + integrity: sha256-qLjNecu7MGJDX0SVkdmN1jcwu78wzi18w6Y3bCNssRE= + prefix: node-v22.23.4-win-arm64 + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-win-arm64.zip + targets: + - cpu: arm64 + os: win32 + - resolution: + archive: zip + bin: node.exe + integrity: sha256-y8dLXgmCydu0FSX9j7Xc0y++4jeGP3gpBy9GOaHOXyA= + prefix: node-v22.23.4-win-x64 + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-win-x64.zip + targets: + - cpu: x64 + os: win32 + - resolution: + archive: zip + bin: node.exe + integrity: sha256-fWxNzi7MzKRuPEs+Q8i+u9GWm9YW/bT9oegmkXHZzOo= + prefix: node-v22.23.4-win-x86 + type: binary + url: https://nodejs.org/download/release/v22.23.4/node-v22.23.4-win-x86.zip + targets: + - cpu: x86 + os: win32 + version: 22.23.4 + hasBin: true + object-assign@4.1.1: resolution: {integrity: sha512-rJgTQnkUnH1sFw8yT6VSU3zD3sWmu6sZhIseY8VX+GRu3P6F7Fu+JNDoXfklElbLJSnc3FUQHVe4cU5hj+BcUg==} engines: {node: '>=0.10.0'} @@ -934,6 +1055,8 @@ snapshots: dependencies: content-type: 2.1.0 + node@runtime:22.23.4: {} + object-assign@4.1.1: {} object-inspect@1.13.4: {} From 4c0c12beedd52a21ca9a3c07669632ee8ba622ba Mon Sep 17 00:00:00 2001 From: S2D2 Date: Wed, 11 Nov 2026 11:51:34 +0000 Subject: [PATCH 3/3] ci: re-run checks The previous run failed one thread-timing test unrelated to this change (0 failures in 40 local runs); the app token cannot re-run jobs. Co-Authored-By: Claude Opus 5.5 Co-authored-by: Guillaume Lebedel <10488548+glebedel@users.noreply.github.com>