From debc4119c055c2d5d50dd8b4e3b9ded223cd2e02 Mon Sep 17 00:00:00 2001 From: Guillaume Date: Mon, 26 Oct 2026 14:26:39 +0000 Subject: [PATCH 1/4] ci: bump Node to 22.x for CVE-2026-111497 Refs SEC-104. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/node-ci.yml | 2 +- .github/workflows/release-please.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index 76a580e..c983894 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -10,7 +10,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 with: - node-version: '20.18.x' + node-version: '22.x' cache: 'npm' - name: Install dependencies run: npm ci diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 4a074bb..81522bb 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -22,7 +22,7 @@ jobs: uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 if: steps.release.outputs.paths_released != '[]' with: - node-version: '20.18.x' + node-version: '22.x' registry-url: 'https://registry.npmjs.org' - name: Build if: steps.release.outputs.paths_released != '[]' From 44848274f5c504f1b781ccd35b535cdc3c1bb0d7 Mon Sep 17 00:00:00 2001 From: S2D2 Date: Mon, 26 Oct 2026 15:03:38 +0000 Subject: [PATCH 2/4] ci: pin Node 22.23.4 exactly instead of floating 22 setup-node defaults check-latest to false, so a floating 22 can resolve to a cached Node 22 older than 22.23.4. Addresses review feedback. Refs SEC-104. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/node-ci.yml | 2 +- .github/workflows/release-please.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index c983894..fd67457 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -10,7 +10,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 with: - node-version: '22.x' + node-version: '22.23.4' cache: 'npm' - name: Install dependencies run: npm ci diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 81522bb..6856c9a 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -22,7 +22,7 @@ jobs: uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 if: steps.release.outputs.paths_released != '[]' with: - node-version: '22.x' + node-version: '22.23.4' registry-url: 'https://registry.npmjs.org' - name: Build if: steps.release.outputs.paths_released != '[]' From a9a5a10ecb130f31b758d1884ec0dd0393970413 Mon Sep 17 00:00:00 2001 From: S2D2 Date: Mon, 26 Oct 2026 16:27:26 +0000 Subject: [PATCH 3/4] ci(SEC-104): read the Node version from package.json in workflows Workflows pinned Node separately from the repo's own version source, so every Node bump had to be made twice. setup-node now reads node-version-file: package.json, which makes package.json the only place to change. - volta.node goes from 20.18.1 to 22.23.4 to match what CI already runs. - .github/workflows/node-ci.yml: 1 step (was 22.23.4). - .github/workflows/release-please.yml: 1 step (was 22.23.4). Requested by guillaume@stackone.com in Slack. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/node-ci.yml | 2 +- .github/workflows/release-please.yml | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index fd67457..a053b15 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -10,7 +10,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 with: - node-version: '22.23.4' + node-version-file: package.json cache: 'npm' - name: Install dependencies run: npm ci diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 6856c9a..eb7eb6b 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -22,7 +22,7 @@ jobs: uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 if: steps.release.outputs.paths_released != '[]' with: - node-version: '22.23.4' + node-version-file: package.json registry-url: 'https://registry.npmjs.org' - name: Build if: steps.release.outputs.paths_released != '[]' diff --git a/package.json b/package.json index b64deef..3abd3d4 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ }, "homepage": "https://github.com/StackOneHQ/file-picker#readme", "volta": { - "node": "20.18.1", + "node": "22.23.4", "npm": "10.8.2" }, "devDependencies": { From a07f07d82504aeeda29bdfd83b5ad7212127b5db Mon Sep 17 00:00:00 2001 From: S2D2 Date: Wed, 11 Nov 2026 17:39:21 +0000 Subject: [PATCH 4/4] chore(SEC-104): pin the November 2026 Node security release Keeps this branch from reintroducing a pre-fix Node when it merges. https://nodejs.org/en/blog/vulnerability/november-2026-security-releases Co-Authored-By: Claude Opus 5.5 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c285c17..1b823de 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ }, "homepage": "https://github.com/StackOneHQ/file-picker#readme", "volta": { - "node": "22.23.4", + "node": "22.23.5", "npm": "10.8.2" }, "devDependencies": {