From 29898ee346fe317f15d706729a3cbb5439e608a6 Mon Sep 17 00:00:00 2001 From: Dev <9416650+aoinoikaz@users.noreply.github.com> Date: Thu, 12 Nov 2026 06:13:57 -0500 Subject: [PATCH] CI: a push to main does not cancel a running deploy cancel-in-progress applied to every ref, and deploy-server runs on a push to main, so a second push during a deploy cancelled it. A cancel between the deploy's systemctl stop and systemctl start left the public cache down with nothing to start it. Only a pull request's run is cancelled by a newer push to it, as in nova-nix's ci.yml. --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fdc0ab2..20ca26c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,9 +14,13 @@ env: permissions: contents: read +# A newer push to a pull request supersedes the run in flight, so that one +# is cancelled. A run on main is never cancelled: it deploys the server, +# and a cancel between the deploy's stop and start leaves the public cache +# down with nothing to start it. concurrency: group: ci-${{ github.ref }} - cancel-in-progress: true + cancel-in-progress: ${{ github.event_name == 'pull_request' }} # --------------------------------------------------------------------------- # Lint jobs (fast, Linux-only)